There is a few tricks to the Gold/Silver/Crystal games. Always keep your pokemon happy and strong by taking them to the haircut brothers once in a while. Also, if you have finished the game and are just getting all 251, battle the elite four quite often so your pokemon will be strong and fit.